fix: return JSON objects from SHOW COLLECTIONS/DATABASES commands#21
Merged
fix: return JSON objects from SHOW COLLECTIONS/DATABASES commands#21
Conversation
SHOW COLLECTIONS, SHOW DATABASES, and db.getCollectionNames() returned
plain strings which couldn't be parsed by the frontend's lossless-json.
Now returns JSON objects with a "name" field: {"name": "collection_name"}
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request fixes a frontend JSON parsing error by changing the output format of SHOW COLLECTIONS, SHOW DATABASES, and db.getCollectionNames() commands to return JSON objects with a name field instead of plain strings.
Changes:
- Modified
executeShowDatabasesandexecuteShowCollectionsto wrap names in JSON objects with{"name": <name>}format - Updated all test cases to unmarshal and validate JSON object format
- Added helper functions in tests to check for database/collection names in JSON format
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/executor/server.go | Modified executeShowDatabases to return JSON objects with "name" field instead of plain strings |
| internal/executor/database.go | Modified executeShowCollections to return JSON objects with "name" field instead of plain strings |
| database_test.go | Updated tests to parse and validate JSON object format; removed unused slices import |
| admin_test.go | Updated tests to use helper functions that parse JSON objects; removed unused slices import; added containsCollectionName and containsDatabaseName helper functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rebelice
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHOW COLLECTIONS,SHOW DATABASES, anddb.getCollectionNames()namefield instead of plain stringsTest plan
🤖 Generated with Claude Code